Skip to content

Fix output ordering#488

Merged
NSoiffer merged 2 commits intodaisy:mainfrom
moritz-gross:fix/order-by-line-number-instead-of-alphabetical
Feb 16, 2026
Merged

Fix output ordering#488
NSoiffer merged 2 commits intodaisy:mainfrom
moritz-gross:fix/order-by-line-number-instead-of-alphabetical

Conversation

@moritz-gross
Copy link
Contributor

@moritz-gross moritz-gross commented Feb 14, 2026

Marthe requested if we could order by line-number instead of alphabetically, which I think makes a lot of sense.


side note: we could add uv run pytest (called inside PythonScripts) to CI.

how does GitHub Actions work with dependency tools like cargo/uv? Is cargo build run from scratch every time before testing? looks like it to me (https://github.com/daisy/MathCAT/actions/runs/22022276872/job/63633257352?pr=488). should we look into caching some of this to not run into any limits?

@moritz-gross
Copy link
Contributor Author

image

and there now is a new symbol in the "files changed" overview. 🤔
looks like it worked.

@moritz-gross
Copy link
Contributor Author

@NSoiffer I want to do a second change that may or may not lead to a merge conflict with this one (another small UX improvement).

What is the right way to handle this? should I branch of from this branch locally and make another PR directly, or first check locally if the can be resolved, or is there a good way to have like nested PRs in GitHub?

I'm not that savvy with Git/GitHub, so I'd have to look into this in more detail to have an informed opinion.

@moritz-gross moritz-gross changed the title Fix condition diff output ordering and deduplication Fix output ordering Feb 16, 2026
@NSoiffer
Copy link
Collaborator

I'm not savvy with GitHub either. My guess is that you should be able to tell locally whether there is a problem by making sure your files are up to date.

@moritz-gross
Copy link
Contributor Author

moritz-gross commented Feb 16, 2026

I'm not savvy with GitHub either. My guess is that you should be able to tell locally whether there is a problem by making sure your files are up to date.

hm ok. just did that, this PR is also good to go.

and good to see that the python tests finished in 9 seconds.
running them locally takes less than 1 second, so the vast majority is setup then.

@NSoiffer NSoiffer merged commit 6126970 into daisy:main Feb 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments